Show 404 on invalid contract address in contract page #5140

MananTank · 2024-10-23T15:16:53Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR enhances the Layout component by adding a validation check for the contractAddress parameter to ensure it is a valid address. If the address is invalid, it returns a not found response.

Detailed summary

Added isAddress import from thirdweb/utils.
Implemented a check using isAddress to validate props.params.contractAddress.
Returns notFound() if the address is invalid.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-10-23T15:16:55Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 23, 2024 4:55pm

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Oct 23, 2024 4:55pm
thirdweb_playground	⬜️ Skipped (Inspect)	Oct 23, 2024 4:55pm
wallet-ui	⬜️ Skipped (Inspect)	Oct 23, 2024 4:55pm

changeset-bot · 2024-10-23T15:16:56Z

⚠️ No Changeset found

Latest commit: eaeb532

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-10-23T15:16:58Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

MananTank · 2024-10-23T15:17:08Z

Show 404 on invalid contract address in contract page #5140 👈
Show 404 on deprecated chain contract page #5139
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite

codecov · 2024-10-23T15:18:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.43%. Comparing base (09b7404) to head (eaeb532).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5140   +/-   ##
=======================================
  Coverage   45.43%   45.43%           
=======================================
  Files        1066     1066           
  Lines       55150    55150           
  Branches     3974     3974           
=======================================
  Hits        25055    25055           
  Misses      29403    29403           
  Partials      692      692

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 09b7404
packages	`40.45% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

github-actions · 2024-10-23T15:20:34Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	42.81 KB (0%)	857 ms (0%)	190 ms (+124.05% 🔺)	1.1 s
thirdweb (cjs)	102.66 KB (0%)	2.1 s (0%)	247 ms (+25.96% 🔺)	2.3 s
thirdweb (minimal + tree-shaking)	4.84 KB (0%)	97 ms (0%)	45 ms (+573.09% 🔺)	141 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	72 ms (+2691.41% 🔺)	82 ms
thirdweb/react (minimal + tree-shaking)	17.33 KB (0%)	347 ms (0%)	64 ms (+189.6% 🔺)	411 ms

jnsdls · 2024-10-23T16:30:45Z

apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/layout.tsx

+  if (!isAddress(props.params.contractAddress)) {
+    return notFound();
+  }


again this should be a special error case down the line

graphite-app · 2024-10-23T16:51:20Z

Merge activity

Oct 23, 12:51 PM EDT: A user added this pull request to the Graphite merge queue.
Oct 23, 12:56 PM EDT: A user merged this pull request with the Graphite merge queue.

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR enhances the `Layout` component by adding a validation check to ensure that the `contractAddress` parameter is a valid address using `isAddress`. If the address is invalid, it returns a "not found" response. ### Detailed summary - Imported `isAddress` from `thirdweb/utils`. - Added a check to validate `props.params.contractAddress` using `isAddress`. - If the address is invalid, the function returns `notFound()`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

vercel bot temporarily deployed to Preview – wallet-ui October 23, 2024 15:16 Inactive

vercel bot temporarily deployed to Preview – docs-v2 October 23, 2024 15:16 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground October 23, 2024 15:16 Inactive

MananTank marked this pull request as ready for review October 23, 2024 15:17

MananTank requested review from jnsdls and joaquim-verges as code owners October 23, 2024 15:17

github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 23, 2024

MananTank mentioned this pull request Oct 23, 2024

Show 404 on deprecated chain contract page #5139

Merged

vercel bot deployed to Preview – thirdweb-www October 23, 2024 15:26 View deployment

jnsdls approved these changes Oct 23, 2024

View reviewed changes

MananTank force-pushed the 10-23-show_404_on_deprecated_chain_contract_page branch from c1230e6 to 09b7404 Compare October 23, 2024 16:52

MananTank force-pushed the 10-23-show_404_on_invalid_contract_address_in_contract_page branch from fa3d5ba to eaeb532 Compare October 23, 2024 16:52

vercel bot temporarily deployed to Preview – thirdweb_playground October 23, 2024 16:52 Inactive

vercel bot temporarily deployed to Preview – wallet-ui October 23, 2024 16:52 Inactive

vercel bot temporarily deployed to Preview – docs-v2 October 23, 2024 16:52 Inactive

vercel bot deployed to Preview – thirdweb-www October 23, 2024 16:55 View deployment

Base automatically changed from 10-23-show_404_on_deprecated_chain_contract_page to main October 23, 2024 16:55

graphite-app bot merged commit eaeb532 into main Oct 23, 2024
29 checks passed

graphite-app bot deleted the 10-23-show_404_on_invalid_contract_address_in_contract_page branch October 23, 2024 16:56

vercel bot temporarily deployed to Production – thirdweb_playground October 23, 2024 16:56 Inactive

vercel bot temporarily deployed to Production – docs-v2 October 23, 2024 16:56 Inactive

vercel bot temporarily deployed to Production – wallet-ui October 23, 2024 16:56 Inactive

vercel bot deployed to Production – thirdweb-www October 23, 2024 17:14 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Show 404 on invalid contract address in contract page #5140

Show 404 on invalid contract address in contract page #5140

Uh oh!

MananTank commented Oct 23, 2024 •

edited by pr-codex bot

Loading

Uh oh!

vercel bot commented Oct 23, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Oct 23, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 23, 2024

Uh oh!

MananTank commented Oct 23, 2024 •

edited

Loading

Uh oh!

codecov bot commented Oct 23, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Oct 23, 2024 •

edited

Loading

Uh oh!

jnsdls Oct 23, 2024

Uh oh!

graphite-app bot commented Oct 23, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Show 404 on invalid contract address in contract page #5140

Show 404 on invalid contract address in contract page #5140

Uh oh!

Conversation

MananTank commented Oct 23, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

graphite-app bot commented Oct 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

MananTank commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

jnsdls Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MananTank commented Oct 23, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Oct 23, 2024 •

edited

Loading

changeset-bot bot commented Oct 23, 2024 •

edited

Loading

MananTank commented Oct 23, 2024 •

edited

Loading

codecov bot commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited

Loading

graphite-app bot commented Oct 23, 2024 •

edited

Loading